search

faradayio / cage

Develop and deploy complex Docker applications
http://cage.faraday.io
Apache License 2.0
307 stars 26 forks source link

Auto-`up` after `mount` and `unmount`? #36

Closed emk closed 7 years ago

emk commented 7 years ago

After running the mount and unmount commands, automatically re-run up.

Potential drawbacks: We might start services that weren't running before.

erithmetic commented 7 years ago

I'm not sure this is a good idea. I used to have all kinds of helpers like this in the old cage but they ended up being a nuisance 80% of the time.

emk commented 7 years ago

Yeah, that's an excellent point. If we do this at all, it probably ought to wait until after we have the ability to poll Docker and see which pods/containers are currently up, and which would need to be restarted. Moving off of milestone and into RFC status for further discussion.

emk commented 7 years ago

There doesn't currently seem to be any consensus that this is a good idea.

I suppose that we could be a bit more precise, now that we have detailed container state: We could selectively re-up only those services that are (1) affected by the volume mount change and (2) already running in the user's environment.

But I'm not convinced this is actually a good idea, especially now that we warn the user to re-run up after they run mount.

emk commented 7 years ago

Yeah, after consideration, I'm closing this RFC for now. Thank you for your feedback!