fix(windows): new hello test

faradayio / cage

Develop and deploy complex Docker applications

http://cage.faraday.io

Apache License 2.0

307 stars 26 forks source link

fix(windows): new hello test #47

Closed dudymas closed 7 years ago

dudymas commented 7 years ago

Simple fix for #44

I'm kind of surprised at having to alternate path dividers. if you think this should be more in depth and this fix is too cosmetic, just say so. I definitely smell something funny in this fix

dudymas commented 7 years ago

Also, I don't know how you folks like long lines for conditionals. I wouldn't mind keeping the 80 character column limit, but I also understand if you want the conditional to be unbroken

dudymas commented 7 years ago

I tried making another change to have the new_example function use PathBuf but then I got dozens of test failures (code compiled just fine). Don't know why yet... I'm guessing somehow adding a mutable type causes state to carry in the worst way?