faradayio / cage

Develop and deploy complex Docker applications
http://cage.faraday.io
Apache License 2.0
307 stars 26 forks source link

`cage test` caveats and possible affordances #51

Closed seamusabshere closed 7 years ago

seamusabshere commented 7 years ago

i think we should bake more intelligence into cage test

Easy way to get a false negative: forgetting to run cage --target test up

Proposed solution: detect somehow if the test target isn't "up" (yes, this makes assumptions about target naming)

Easy way to get a false positive: forgetting to cage source mount after you change a test

Proposed solution: warn if testing against an unmounted service

emk commented 7 years ago

These both sound like excellent ideas!

detect somehow if the test target isn't "up"

The best way to do this is to look for pods which are enabled in test mode (according to cage status) but which contain services that are not RUNNING. This is actually pretty simple and well-defined.

warn if testing against an unmounted service

Yeah, this seems reasonable enough.

emk commented 7 years ago

Part of this is already mentioned under #6.