farahats9 / sqlalchemy-celery-beat

Celery Periodic Tasks backed by the SQLAlchemy
MIT License
43 stars 6 forks source link

zoneinfo issues for Python versions 3.9 and below #2

Open BrQE opened 7 months ago

BrQE commented 7 months ago

fixed zoneinfo issues for Python versions 3.9 and below.

farahats9 commented 7 months ago

Thank you for your contribution, zoneinfo is already supported in Python 3.9+ This appears to add an external package backports.zoneinfo and it needs to be conditional based on python version for 3.8 and below only, can you update you PR to add these changes?

BrQE commented 7 months ago

Of cource, updated PR, I thank you, especially, for deciding to update this library.

farahats9 commented 6 months ago

Sorry I wasn't clear, your original code was correct. I meant it should be added in the setup.py and the requirements files as a conditional based on the version of python it should install these backports dependencies.