search

farbodbj / GuardianNews

Simple online news feed app using Guardian Open platform based on clean architecture and best practices.
1 stars 0 forks source link

Best practice #15

Closed keramat-farid closed 11 months ago

keramat-farid commented 11 months ago

There is a extension function called asLiveData that you can use to convert flow to live data. Its better to remove all the references to live data so you can understand collecting in fragment difficulties.

https://github.com/farbodbj/GuardianNews/blob/1ff5d7e1cf82eaffe30e24b5a9e17030fdd5e615/app/src/main/java/com/bale_bootcamp/guardiannews/ui/news/NewsFragmentViewModel.kt#L33

farbodbj commented 11 months ago

the fix for this issue is now at branch issue_15 and is under testing

farbodbj commented 11 months ago

issue fixed in latest PR