search

farbodbj / GuardianNews

Simple online news feed app using Guardian Open platform based on clean architecture and best practices.
1 stars 0 forks source link

Refresh on resume #16

Closed keramat-farid closed 11 months ago

keramat-farid commented 11 months ago

Why are you trying to refresh your list onResume?

https://github.com/farbodbj/GuardianNews/blob/1ff5d7e1cf82eaffe30e24b5a9e17030fdd5e615/app/src/main/java/com/bale_bootcamp/guardiannews/ui/news/NewsFragment.kt#L108

farbodbj commented 11 months ago

The refreshAPagingAdapter() was put in onResume to refresh the adapter only when it is empty but the conditions for emptiness were left unchecked. Needed conditions for adapter emptiness are now checked but this call may not be needed at all. It will be removed after ensuring its uselessness.

farbodbj commented 11 months ago

issue fixed after latest PR