search

farbodbj / GuardianNews

Simple online news feed app using Guardian Open platform based on clean architecture and best practices.
1 stars 0 forks source link

Wrong place to setup view #5

Closed keramat-farid closed 11 months ago

keramat-farid commented 11 months ago

You should not do anything time consuming inside onCreateView. The view setup must be inside onViewCreated https://github.com/farbodbj/GuardianNews/blob/47fa4e005c8bd70f028b2b5218d904e96c77d8b6/app/src/main/java/com/bale_bootcamp/guardiannews/NewsFragment.kt#L44C9-L44C9

farbodbj commented 11 months ago

time consuming logic moved to onViewCreated