farcaster-project / farcaster-node

Farcaster cross-chain atomic swap node.
https://crates.io/crates/farcaster_node
MIT License
103 stars 19 forks source link

Connect a specific version of node to farcaster.dev for tests #287

Closed h4sh3d closed 2 years ago

h4sh3d commented 2 years ago

Website farcaster.dev can take a list of public offers, a special version of the node should be able to push offers there (the "maker" version) and the standard version should have a command to list them in cli.

h4sh3d commented 2 years ago

As @zkao mentioned, if we are able to list offers from the cli there is no need to have a special node version, we can just script to list and update every x time.

I though about what the cli could look like and came up with this idea:

swap-cli ls <TYPE>

where TYPE is by defaults swaps with ls swaps being the current ls behavior and ls offers being the list of offers like:

---
- "Offer:Cke4ftrP5A71LQM2fvVdFMNR4gumFhEqm11111uMFq7cEPSbSQpvEiF11111TB9zym113GTvtvqfD1111114A4TULEXhypzp8nJ4WAGAZUdDkYai3i9KTgUHkGLs5zX3N1tA11111111111111111111111111111111111111111AfZ113XRBuJApN3x"
zkao commented 2 years ago

ls stands for list swaps

why reuse?

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Saturday, December 4th, 2021 at 9:55 AM, h4sh3d @.***> wrote:

As @.***(https://github.com/zkao) mentioned, if we are able to list offers from the cli there is no need to have a special node version, we can just script to list and update every x time.

I though about what the cli could look like and came up with this idea:

swap-cli ls

where TYPE is by defaults swaps with ls swaps being the current ls behavior and ls offers being the list of offers like:


  • "Offer:Cke4ftrP5A71LQM2fvVdFMNR4gumFhEqm11111uMFq7cEPSbSQpvEiF11111TB9zym113GTvtvqfD1111114A4TULEXhypzp8nJ4WAGAZUdDkYai3i9KTgUHkGLs5zX3N1tA11111111111111111111111111111111111111111AfZ113XRBuJApN3x"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

h4sh3d commented 2 years ago

I though ls was for list

zkao commented 2 years ago

maybe we should call it ListSwaps, and the abbreviation is ls, and the other ListOffers ?

Lederstrumpf commented 2 years ago

created https://github.com/farcaster-project/offer-refiller to address this. It's pushing public offers to the web frontend whenever the list of swaps offered is updated.