Closed varunsrin closed 1 year ago
Coverage after merging varunsrin/hook-forge-fmt-check into main will be
98.79% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 94.12% | 83.33% | 100% | 100% | 125, 127 |
FnameResolver.sol | 96.30% | 75% | 100% | 100% | 121 |
IdRegistry.sol | 97.30% | 100% | 92.31% | 97.44% | 315 |
StorageRent.sol | 98.85% | 98.44% | 100% | 98.90% | 468, 470 |
Motivation
The current hook runs the
forge fmt
without--check
which formats files with issues silently, but doesn't check them in causing CI to fail when pushed later.Change Summary
Change to fail loudly when committing if the any files have formatting issues, so that they must be fixed before a commit is made.
Merge Checklist
PR-Codex overview
This PR focuses on updating the pre-commit command in
.rusty-hook.toml
to include the--check
flag forforge fmt
, ensuring code formatting is checked. Additionally, theverbose
flag is set to true in the[logging]
section.Detailed summary
--check
flag forforge fmt
verbose
flag to true in[logging]
section