farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

feat: add KeyRegistry #257

Closed horsefacts closed 1 year ago

horsefacts commented 1 year ago

Motivation

Implements FIP: Onchain Signers, fixing #255.

Change Summary

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

Also closes #258


PR-Codex overview

This PR focuses on adding an owner parameter to the constructors of IdRegistry, FnameResolver, Bundler, and KeyRegistry contracts. It also updates the test suites and harnesses accordingly.

Detailed summary

The following files were skipped due to too many changes: src/KeyRegistry.sol, test/KeyRegistry/KeyRegistry.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging horsefacts/signer-registry into main will be

98.13%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol96.30%75%100%100%122
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRent.sol98.90%98.48%100%98.96%519, 521
src/lib
   TransferHelper.sol0%0%0%0%15, 15, 15, 25–26, 26, 26