fix: use explicit owner address everywhere

Motivation

In the current TestSuiteSetup contract, we assign address(this) (i.e. the test contract address) as owner and use this value throughout the tests. Since the test contract is the owner, we don't need to use vm.prank to make authenticated calls.

This is convenient, but it makes it harder to test that ownership is configured correctly. In practice the owner will not be the deployer: since we'll be deploying contracts using a CREATE2 factory, we want to transfer ownership to an explicit address at construction time. If the test contract itself is set as the owner, it's difficult to tell whether we're relying on the default behavior of Ownable or transferring ownership correctly. (And in fact, in IdRegistry, we weren't transferring ownership to the _owner arg in the constructor, see #280 ).

Change Summary

Generate an explicit address for owner using makeAddr and use it throughout the tests. Replace admin with owner in key registry and resolver tests.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The PR title adheres to the conventional commits standard
[x] The PR has been tagged with change type label(s) (i.e. documentation, feature, bugfix, or chore)
[x] The PR's changes adhere to all the requirements in the contribution guidelines
[x] This PR does not require changes to the Farcaster protocol

Additional Context

Fixes unused _owner argument in IdRegistry constructor.

Close #280

PR-Codex overview

Focus of this PR:

This PR focuses on making changes to several contracts and tests related to the IdRegistry, FnameResolver, and Bundler functionality.

Detailed summary:

In TestSuiteSetup.sol, the owner variable is changed to makeAddr("owner").
In IdRegistry.sol, the constructor is modified to include a call to _transferOwnership(_owner).
In KeyRegistryTestSuite.sol, the admin variable is changed to makeAddr("admin") and the setUp function is modified to include a call to vm.prank(owner).
In IdRegistryTestSuite.sol, the _registerWithRecovery function is modified to include a call to vm.prank(owner).
In IdRegistry.gas.t.sol, the testGasRegister and testGasRegisterForAndRecover functions are modified to include a call to vm.prank(owner).
In Bundler.gas.t.sol, the testGasRegisterWithSig, testGasTrustedRegister, and testGasTrustedBatchRegister functions are modified to include a call to vm.prank(owner).
In FnameResolverTestSuite.sol, the import statements for forge-std/Test.sol and openzeppelin/contracts/utils/cryptography/EIP712.sol are removed and replaced with import statements for TestSuiteSetup.sol and FnameResolverHarness.
In IdRegistry.owner.t.sol, several functions are modified to include a call to vm.prank(owner).
In FnameResolver.t.sol, the testInitialOwner function is modified to check for owner instead of admin.
In IdRegistry.t.sol, several functions are modified to include a call to vm.prank(owner).
In Bundler.t.sol, the testFuzzTrustedRegister and testFuzzCannotTrustedRegisterWhenPaused functions are modified to include a call to vm.prank(owner).

The following files were skipped due to too many changes: test/Bundler/Bundler.t.sol, test/KeyRegistry/KeyRegistry.t.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Bundler.sol	100%	100%	100%	100%
FnameResolver.sol	96.30%	75%	100%	100%	122
IdRegistry.sol	100%	100%	100%	100%
KeyRegistry.sol	100%	100%	100%	100%
StorageRent.sol	98.90%	98.48%	100%	98.96%	532, 534
src/lib
TransferHelper.sol	0%	0%	0%	0%	15, 15, 15, 25–26, 26, 26

farcasterxyz / contracts