chore: upgrade solidity to 0.8.21, keep evm_version at paris

varunsrin commented 1 year ago

Motivation

Upgrade to the newer solidity version so we can take advantage of new features like importing events. Pin the evm version to paris, since shanghai's push0 isn't supported by many l2s.

Change Summary

Upgrade solidity to 0.8.21
Pin evm_version to paris

Merge Checklist

[x] The PR title adheres to the conventional commits standard
[x] The PR has been tagged with change type label(s) (i.e. documentation, feature, bugfix, or chore)
[x] The PR's changes adhere to all the requirements in the contribution guidelines
[x] This PR does not require changes to the Farcaster protocol

PR-Codex overview

Focus of the PR:

Update Solidity version to 0.8.21 and make necessary imports and pragma changes.

Detailed summary:

Updated Solidity version from 0.8.19 to 0.8.21 in multiple files.
Updated solc_version in foundry.toml from "0.8.19" to "0.8.21".
Updated pragma solidity version in multiple files from 0.8.19 to 0.8.21.
Updated evm_version in foundry.toml from "paris".
Updated pragma solidity version in multiple files from 0.8.19 to 0.8.21.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging varunsrin/upgrade-solidity into main will be

98.13%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Bundler.sol	100%	100%	100%	100%
FnameResolver.sol	96.30%	75%	100%	100%	122
IdRegistry.sol	100%	100%	100%	100%
KeyRegistry.sol	100%	100%	100%	100%
StorageRent.sol	98.90%	98.48%	100%	98.96%	530, 532
src/lib
TransferHelper.sol	0%	0%	0%	0%	15, 15, 15, 25–26, 26, 26

horsefacts commented 1 year ago

LGTM. A cleanup pass PR to use some of these features would be useful. In addition to event imports, I think there are a few places we can use named mappings as well.

farcasterxyz / contracts