Closed horsefacts closed 1 year ago
Coverage after merging horsefacts/erc-1271-signatures into main will be
98.69% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 100% | 100% | 100% | 100% | |
FnameResolver.sol | 100% | 100% | 100% | 100% | |
IdRegistry.sol | 100% | 100% | 100% | 100% | |
KeyRegistry.sol | 100% | 100% | 100% | 100% | |
StorageRent.sol | 100% | 100% | 100% | 100% | |
src/lib | |||||
Signatures.sol | 100% | 100% | 100% | 100% | |
TransferHelper.sol | 0% | 0% | 0% | 0% | 15, 15, 15, 25–26, 26, 26 |
TrustedCaller.sol | 100% | 100% | 100% | 100% |
Motivation
Users should be able to perform signature-authenticated actions like fid registration/transfer and key registration from smart contract wallets.
Change Summary
Replace
ECDSA
with OpenZeppelinSignatureChecker
in theSignatures
helper.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers.
PR-Codex overview
This PR focuses on replacing the usage of
ECDSA
library withSignatureChecker
in multiple contracts.Detailed summary
ECDSA
library import withSignatureChecker
import inSignatures.sol
"ECDSA: invalid signature"
revert message withSignatures.InvalidSignature.selector
inKeyRegistry.t.sol
andIdRegistry.t.sol