farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

chore: coverage fixups #287

Closed horsefacts closed 1 year ago

horsefacts commented 1 year ago

Motivation

Recent coverage reports show a couple uncovered lines in StorageRent and FnameResolver.

Change Summary

Add a test for the selector check in FnameResolver and the initial price update in StorageRent.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Focus of the PR:

This PR focuses on adding a new test function testFuzzResolveRevertsNonAddrFunction and updating an existing test function testInitialPriceUpdate.

Detailed summary:

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging horsefacts/coverage-fixups into main will be

98.62%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRent.sol100%100%100%100%
src/lib
   TransferHelper.sol0%0%0%0%15, 15, 15, 25–26, 26, 26