chore: add key registry to deploy script

horsefacts commented 1 year ago

Motivation

We're missing a deploy script for the new KeyRegistry.

Change Summary

Add KeyRegistry to Deploy.s.sol and add a standalone KeyRegistry.s.sol script to deploy only the key registry. I'd like to do a larger pass to make some changes to all the deploy scripts at once, but for now this adds KeyRegistry and follows our established patterns.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The PR title adheres to the conventional commits standard
[x] The PR has been tagged with change type label(s) (i.e. documentation, feature, bugfix, or chore)
[x] The PR's changes adhere to all the requirements in the contribution guidelines
[x] This PR does not require changes to the Farcaster protocol

Additional Context

Close #268

PR-Codex overview

Detailed summary

Added KeyRegistry contract and related changes to Deploy and IdRegistryScript contracts.
Updated environment variable names and values.
Added SPDX license identifier to KeyRegistry contract.
Imported KeyRegistry contract in Deploy contract.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging horsefacts/add-key-registry-to-deploy into main will be

98.16%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Bundler.sol	100%	100%	100%	100%
FnameResolver.sol	96.30%	75%	100%	100%	122
IdRegistry.sol	100%	100%	100%	100%
KeyRegistry.sol	100%	100%	100%	100%
StorageRent.sol	98.93%	98.53%	100%	98.99%	547, 549
src/lib
TransferHelper.sol	0%	0%	0%	0%	15, 15, 15, 25–26, 26, 26

horsefacts commented 1 year ago

Gonna merge this for now and go ahead with the larger deploy script refactor mentioned above.

farcasterxyz / contracts