chore: use ImmutableCreate2Deployer

Motivation

We should have a single, reliable Foundry script that deploys our contracts and abstracts over deployment parameters. We should be able to test this deployment in a forked environment exactly like production.

Change Summary

Add an ImmutableCreate2Deployer base script contract that makes use of the cross-chain ImmutableCreate2Factory. Refactor existing deployment scripts to use it. Add a fork test that exercises the deploy script.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The PR title adheres to the conventional commits standard
[x] The PR has been tagged with change type label(s) (i.e. documentation, feature, bugfix, or chore)
[x] The PR's changes adhere to all the requirements in the contribution guidelines
[x] This PR does not require changes to the Farcaster protocol

Additional Context

Foundry uses Arachnid's keyless CREATE2 factory by default, but there are a few advantages to using 0age's ImmutableCreate2Factory:

It exposes a helpful method to tell if a contract is already deployed.
Its deployments are truly immutable, since the factory ensures the given initcode + salt can only be deployed once.
It optionally prevents deployment frontrunning by requiring the first 20 bytes of the salt to equal the caller address.
In my opinion, it looks a little more legible on Etherscan.

Close #269

PR-Codex overview

Focus of the PR:

This PR focuses on adding testnet and mainnet RPC URLs, as well as making changes to the CI workflow.

Detailed summary:

Added TESTNET_RPC_URL and MAINNET_RPC_URL variables to the .env.example file.
Added TESTNET_RPC_URL and MAINNET_RPC_URL secrets to the CI workflow.
Updated the foundry.toml file to include a match_path and no_match_path for testing purposes.
Added rpc_endpoints section to the foundry.toml file with testnet and mainnet URLs.
Updated the IdRegistryScript, FnameResolverScript, KeyRegistryScript, and StorageRentScript files to use the ImmutableCreate2Deployer contract.
Updated the DeployTest file with new deployment parameters and added test cases.
Added the LocalDeploy script for local deployment.
Updated the README.md file with instructions on running tests and deploying locally.

The following files were skipped due to too many changes: script/LocalDeploy.s.sol, script/lib/ImmutableCreate2Deployer.sol, script/Deploy.s.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
Bundler.sol	100%	100%	100%	100%
FnameResolver.sol	100%	100%	100%	100%
IdRegistry.sol	100%	100%	100%	100%
KeyRegistry.sol	100%	100%	100%	100%
StorageRent.sol	100%	100%	100%	100%
src/lib
Signatures.sol	100%	100%	100%	100%
TransferHelper.sol	0%	0%	0%	0%	15, 15, 15, 25–26, 26, 26
TrustedCaller.sol	100%	100%	100%	100%

farcasterxyz / contracts