bug: idregistry state cannot be frozen for a future upgrade

farcasterxyz / contracts

Implementation of the Farcaster contracts

https://www.farcaster.xyz/

MIT License

340 stars 122 forks source link

bug: idregistry state cannot be frozen for a future upgrade #295

Closed varunsrin closed 1 year ago

varunsrin commented 1 year ago

What is the bug? There is no way to freeze the state of IdRegistry, which is important for a safe upgrade in case a bug is discovered in the future. The closest function is pause, which does not prevent transfers or recoveries. Consider extending pause to freeze all state or add a new one-way method like deprecate which freezes the contract entirely.

horsefacts commented 1 year ago

@varunsrin I think this was closed by #301 Anything remaining?