farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

refactor(StorageRegistry): rename ADMIN role to OWNER #300

Closed varunsrin closed 1 year ago

varunsrin commented 1 year ago

Motivation

The role that performs the majority of administrative functions is called the owner in most contracts except for the StorageRegistry, which refers to it as admin. This PR standardizes the naming to owner.

Change Summary

Merge Checklist

github-actions[bot] commented 1 year ago

Coverage after merging varunsrin/rename-storage-admin-owner into main will be

98.70%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/lib
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%15, 15, 15, 25–26, 26, 26
   TrustedCaller.sol100%100%100%100%