farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

chore: use fcast.id domain #318

Closed horsefacts closed 1 year ago

horsefacts commented 1 year ago

Motivation

Update the fname resolver tests to use the real fname domain, fcast.id.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Focus of the PR:

This PR focuses on updating the FnameResolverTestSuite.sol file by changing the FNAME_SERVER_URL constant and DNS_ENCODED_NAME constant to use the new domain "fcast.id" instead of "farcaster.xyz".

Detailed summary:

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging horsefacts/fcast-id-domain into main will be

98.76%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/lib
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%12, 17, 20, 20, 20
   TrustedCaller.sol100%100%100%100%