Closed horsefacts closed 1 year ago
Coverage after merging horsefacts/skippable-setup into main will be
98.76% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 100% | 100% | 100% | 100% | |
FnameResolver.sol | 100% | 100% | 100% | 100% | |
IdRegistry.sol | 100% | 100% | 100% | 100% | |
KeyRegistry.sol | 100% | 100% | 100% | 100% | |
StorageRegistry.sol | 100% | 100% | 100% | 100% | |
src/lib | |||||
Signatures.sol | 100% | 100% | 100% | 100% | |
TransferHelper.sol | 0% | 0% | 0% | 0% | 12, 17, 20, 20, 20 |
TrustedCaller.sol | 100% | 100% | 100% | 100% |
Motivation
Deploy scripts should be idempotent: if we detect that contracts are already deployed, we should skip the post-deploy setup step.
Change Summary
Update deploy script to skip setup if contracts haven't changed. Add default values to .env.example.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
Detailed summary
/dev/null
forcast rpc
commands indocker-compose.yml
.runSetup
function inDeploy
contract.deploymentChanged
function to check if any contract deployment has occurred inImmutableCreate2Deployer
contract..env.example
file.