farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

feat: Missing event for successful `fid` recovery #337

Closed horsefacts closed 1 year ago

horsefacts commented 1 year ago

In the IdRegistry contract, the recover() function is responsible for performing recovery on behalf of the custody address by transferring the fid to a new address. When this happens, a Transfer event is emitted.

However, for off-chain monitoring tools, it is not easy to differentiate a recovery versus a normal transfer event.

Consider introducing a new event to differentiate between a fid recovery and a normal transfer.