Closed horsefacts closed 1 year ago
Coverage after merging horsefacts/settable-data-feeds into main will be
98.77% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 100% | 100% | 100% | 100% | |
FnameResolver.sol | 100% | 100% | 100% | 100% | |
IdRegistry.sol | 100% | 100% | 100% | 100% | |
KeyRegistry.sol | 100% | 100% | 100% | 100% | |
StorageRegistry.sol | 100% | 100% | 100% | 100% | |
src/lib | |||||
Signatures.sol | 100% | 100% | 100% | 100% | |
TransferHelper.sol | 0% | 0% | 0% | 0% | 12, 17, 20, 20, 20 |
TrustedCaller.sol | 100% | 100% | 100% | 100% |
Motivation
The price feed and data feed in
StorageRegistry
are currentlyimmutable
. However, in the unlikely event of a price or data feed migration/redeployment, we'd like the ability for the contract owner to update these.Change Summary
Move price feed/data feed to storage variables, add events and setter functions.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
Detailed summary
BundleRegistryGasUsageTest
andIdRegistryGasUsageTest
contracts, as well as theStorageRegistry
contract and its associated tests.testGasTrustedBatchRegister
function inBundleRegistryGasUsageTest
totestGasRegisterWithSig
.testGasTrustedBatchRegister
andtestGasTrustedRegister
functions inBundleRegistryGasUsageTest
.testGasRegister
function inIdRegistryGasUsageTest
.SetPriceFeed
andSetUptimeFeed
to theStorageRegistry
contract.setPriceFeed
andsetUptimeFeed
functions in theStorageRegistry
contract to emit the new events.AggregatorV3Interface
from thechainlink/v0.8/interfaces/AggregatorV3Interface.sol
file in theStorageRegistryTest
contract.