farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

feat(StorageRegistry): settable data feeds #349

Closed horsefacts closed 1 year ago

horsefacts commented 1 year ago

Motivation

The price feed and data feed in StorageRegistry are currently immutable. However, in the unlikely event of a price or data feed migration/redeployment, we'd like the ability for the contract owner to update these.

Change Summary

Move price feed/data feed to storage variables, add events and setter functions.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging horsefacts/settable-data-feeds into main will be

98.77%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/lib
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%12, 17, 20, 20, 20
   TrustedCaller.sol100%100%100%100%