Closed horsefacts closed 1 year ago
Coverage after merging horsefacts/key-validator-followups into main will be
98.94% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 100% | 100% | 100% | 100% | |
FnameResolver.sol | 100% | 100% | 100% | 100% | |
IdRegistry.sol | 100% | 100% | 100% | 100% | |
KeyRegistry.sol | 100% | 100% | 100% | 100% | |
StorageRegistry.sol | 100% | 100% | 100% | 100% | |
src/lib | |||||
Signatures.sol | 100% | 100% | 100% | 100% | |
TransferHelper.sol | 0% | 0% | 0% | 0% | 12, 17, 20, 20, 20 |
TrustedCaller.sol | 100% | 100% | 100% | 100% | |
src/validators | |||||
SignedKeyRequestValidator.sol | 100% | 100% | 100% | 100% |
Motivation
Followups from #354
Change Summary
encodeMetadata
view toSignedKeyRequestValidator
. This exposes theSignedKeyRequest
struct in the contract ABI for clients like Viem and can be called directly to encode metadata._registerValidator
helper to explicitly set up validators in all tests, rather than rely on implicitsetUp
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers.
PR-Codex overview
This PR focuses on making changes to the KeyRegistry, Bundler, and SignedKeyRequestValidator contracts.
Detailed summary