Closed horsefacts closed 1 year ago
Coverage after merging horsefacts/inheritdoc into main will be
98.65% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 100% | 100% | 100% | 100% | |
FnameResolver.sol | 100% | 100% | 100% | 100% | |
IdRegistry.sol | 100% | 100% | 100% | 100% | |
KeyRegistry.sol | 100% | 100% | 100% | 100% | |
RecoveryProxy.sol | 100% | 100% | 100% | 100% | |
StorageRegistry.sol | 100% | 100% | 100% | 100% | |
src/lib | |||||
EIP712.sol | 50% | 100% | 50% | 50% | 19 |
Signatures.sol | 100% | 100% | 100% | 100% | |
TransferHelper.sol | 0% | 0% | 0% | 0% | 12, 17, 20, 20, 20 |
TrustedCaller.sol | 100% | 100% | 100% | 100% | |
src/validators | |||||
SignedKeyRequestValidator.sol | 100% | 100% | 100% | 100% |
Motivation
Reduce duplication in natspec comments by using the
@inheritdoc
tag.Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
This PR includes an unrelated fix to a fuzz test missing a
vm.assume
.PR-Codex overview
Detailed summary
isMigrated()
to theIKeyRegistry
interface to check if the contract has been migrated.verifyFidSignature()
to theIIdRegistry
interface to verify if a signature was produced by the custody address that owns an fid.