farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

chore: mine create2 salts #385

Closed horsefacts closed 1 year ago

horsefacts commented 1 year ago

Motivation

Since we're using CREATE2 to deploy our contracts, we can mine salts that generate efficient (leading zeros) or consistent (same prefix) addresses for our contracts.

Change Summary

Add mined CREATE2 salts to DeployL2.s.sol

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Focus of the PR:

This PR focuses on updating the deployment addresses and salts in the DeployL2 contract and its corresponding test.

Detailed summary:

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging horsefacts/deployment-salts into main will be

98.65%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/lib
   EIP712.sol50%100%50%50%19
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%12, 17, 20, 20, 20
   TrustedCaller.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%