Closed horsefacts closed 1 year ago
Coverage after merging horsefacts/deployment-salts into main will be
98.65% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
src | |||||
Bundler.sol | 100% | 100% | 100% | 100% | |
FnameResolver.sol | 100% | 100% | 100% | 100% | |
IdRegistry.sol | 100% | 100% | 100% | 100% | |
KeyRegistry.sol | 100% | 100% | 100% | 100% | |
RecoveryProxy.sol | 100% | 100% | 100% | 100% | |
StorageRegistry.sol | 100% | 100% | 100% | 100% | |
src/lib | |||||
EIP712.sol | 50% | 100% | 50% | 50% | 19 |
Signatures.sol | 100% | 100% | 100% | 100% | |
TransferHelper.sol | 0% | 0% | 0% | 0% | 12, 17, 20, 20, 20 |
TrustedCaller.sol | 100% | 100% | 100% | 100% | |
src/validators | |||||
SignedKeyRequestValidator.sol | 100% | 100% | 100% | 100% |
Motivation
Since we're using CREATE2 to deploy our contracts, we can mine salts that generate efficient (leading zeros) or consistent (same prefix) addresses for our contracts.
Change Summary
Add mined CREATE2 salts to
DeployL2.s.sol
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewPR-Codex overview
Focus of the PR:
This PR focuses on updating the deployment addresses and salts in the
DeployL2
contract and its corresponding test.Detailed summary:
deployer
address in theDeployL2Test
contract.DeployL2Test
contract.DeployL2
contract.