farcasterxyz / contracts

Implementation of the Farcaster contracts
https://www.farcaster.xyz/
MIT License
340 stars 122 forks source link

fix: Zero out salts to get Docker Compose helper working #395

Closed sds closed 1 year ago

sds commented 1 year ago

Motivation

When using this repo for local development, the use of salts seems to interfere with running the l2-deployer container.

Change Summary

Fix by zeroing out the hashes. @horsefacts: is there a way we can override these salts locally via environment variables? (just in the docker-compose.yml so this still works in local dev)

While here, add some tests that confirm the L2 contracts are deployed correctly.

Merge Checklist


PR-Codex overview

The following files were skipped due to too many changes: .env.example, script/DeployL2.s.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

github-actions[bot] commented 1 year ago

Coverage after merging sds/fix-docker-compose into main will be

98.66%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
src/lib
   EIP712.sol50%100%50%50%19
   Signatures.sol100%100%100%100%
   TransferHelper.sol0%0%0%0%12, 17, 20, 20, 20
   TrustedCaller.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%