farcasterxyz / hub-monorepo

Implementation of the Farcaster Hub specification and supporting libraries for building applications on Farcaster
https://www.thehubble.xyz
MIT License
700 stars 392 forks source link

API: `verificationsByFid` returns the same `verificationAddAddressBody` twice #1702

Closed jordipainan closed 7 months ago

jordipainan commented 7 months ago

What is the bug? When calling the exposed API method verificationsByFid on a freshly installed hub the information of the verifications is returned twice.

How can it be reproduced? (optional)

  1. Set up a hubble hub using this instructions.
  2. Call <ENDPOINT>/v1/verificationsByFid?fid=1
  3. Got result
{
  "messages": [
    {
      "data": {
        "type": "MESSAGE_TYPE_VERIFICATION_ADD_ETH_ADDRESS",
        "fid": 1,
        "timestamp": 80525334,
        "network": "FARCASTER_NETWORK_MAINNET",
        "verificationAddAddressBody": {
          "address": "0x86924c37a93734e8611eb081238928a9d18a63c0",
          "claimSignature": "L8CdofTctyNu+5H3eTLCScQYwK8Axm7ZLuHzWwLIDWoRRSgMnzYdIH0oRH+PdGM2aEDTqTaQNs9pVK/R/TMb6xs=",
          "blockHash": "0x191905a9201170abb55f4c90a4cc968b44c1b71cdf3db2764b775c93e7e22b29",
          "verificationType": 0,
          "chainId": 0,
          "protocol": "PROTOCOL_ETHEREUM",
          "ethSignature": "L8CdofTctyNu+5H3eTLCScQYwK8Axm7ZLuHzWwLIDWoRRSgMnzYdIH0oRH+PdGM2aEDTqTaQNs9pVK/R/TMb6xs="
        },
        "verificationAddEthAddressBody": {
          "address": "0x86924c37a93734e8611eb081238928a9d18a63c0",
          "claimSignature": "L8CdofTctyNu+5H3eTLCScQYwK8Axm7ZLuHzWwLIDWoRRSgMnzYdIH0oRH+PdGM2aEDTqTaQNs9pVK/R/TMb6xs=",
          "blockHash": "0x191905a9201170abb55f4c90a4cc968b44c1b71cdf3db2764b775c93e7e22b29",
          "verificationType": 0,
          "chainId": 0,
          "protocol": "PROTOCOL_ETHEREUM",
          "ethSignature": "L8CdofTctyNu+5H3eTLCScQYwK8Axm7ZLuHzWwLIDWoRRSgMnzYdIH0oRH+PdGM2aEDTqTaQNs9pVK/R/TMb6xs="
        }
      },
      "hash": "0x5302f53d93eabfb0edafb9cef1bd8416fd8f9c46",
      "hashScheme": "HASH_SCHEME_BLAKE3",
      "signature": "m6jhQzxqDnS9oLei8ilFPSCt4v1g1lBYoMW1pK3isjucutTLLQLaDn6c3Vw89jBS2+w/E5Vw/XvHUZGgXneRDQ==",
      "signatureScheme": "SIGNATURE_SCHEME_ED25519",
      "signer": "0xb85cf7feef230f30925b101223fd3e3dc4e1120bacd677f5ad3523288f8f7102"
    }
  ],
  "nextPageToken": ""
}
  1. Expected result:
    {
    "messages": [
    {
      "data": {
        "type": "MESSAGE_TYPE_VERIFICATION_ADD_ETH_ADDRESS",
        "fid": 1,
        "timestamp": 80525334,
        "network": "FARCASTER_NETWORK_MAINNET",
        "verificationAddAddressBody": {
          "address": "0x86924c37a93734e8611eb081238928a9d18a63c0",
          "claimSignature": "L8CdofTctyNu+5H3eTLCScQYwK8Axm7ZLuHzWwLIDWoRRSgMnzYdIH0oRH+PdGM2aEDTqTaQNs9pVK/R/TMb6xs=",
          "blockHash": "0x191905a9201170abb55f4c90a4cc968b44c1b71cdf3db2764b775c93e7e22b29",
          "verificationType": 0,
          "chainId": 0,
          "protocol": "PROTOCOL_ETHEREUM",
          "ethSignature": "L8CdofTctyNu+5H3eTLCScQYwK8Axm7ZLuHzWwLIDWoRRSgMnzYdIH0oRH+PdGM2aEDTqTaQNs9pVK/R/TMb6xs="
        }
      },
      "hash": "0x5302f53d93eabfb0edafb9cef1bd8416fd8f9c46",
      "hashScheme": "HASH_SCHEME_BLAKE3",
      "signature": "m6jhQzxqDnS9oLei8ilFPSCt4v1g1lBYoMW1pK3isjucutTLLQLaDn6c3Vw89jBS2+w/E5Vw/XvHUZGgXneRDQ==",
      "signatureScheme": "SIGNATURE_SCHEME_ED25519",
      "signer": "0xb85cf7feef230f30925b101223fd3e3dc4e1120bacd677f5ad3523288f8f7102"
    }
    ],
    "nextPageToken": ""
    }

Additional context (optional) None

sanjayprabhu commented 7 months ago

This is intentional. We renamed the field from verificationAddEthAddressBody to verificationAddAddressBody. To preserve backwards compatibility, we're returning both fields right now. We'll remove the old one once clients have had a chance to migrate.

jordipainan commented 7 months ago

Gotcha! Thank you for the response.