search

farcasterxyz / hub-monorepo

Implementation of the Farcaster Hub specification and supporting libraries for building applications on Farcaster
https://www.thehubble.xyz
MIT License
715 stars 417 forks source link

feat(shuttle): Shuttle should rewind a few seconds in the event stream on restart #2172

Open sanjayprabhu opened 4 months ago

sanjayprabhu commented 4 months ago

What is the feature you would like to implement? Shuttle resumes from the last saved event id always. But sometimes it's possible for events to be emitted out of order. To be safe, it should rewind a small number of seconds (1-5?) from the most recent event id when it resumes after a restart. We could make this configurable.

Why is this feature important? An argument for why this feature should be built and how it should be prioritized

Will the protocol spec need to be updated?? Call out the sections of the protocol spec that will need to be updated (e.g. Section 4.3 - Verifications, Section 3.1 - Identity Systems)

How should this feature be built? (optional) A design for the implementation of the feature

Additional context Add any other context or screenshots about the feature request here.

Rufusemmanuel commented 2 months ago

I think I once talked about this and it should be treated with urgency