farcasterxyz / hub-monorepo

Implementation of the Farcaster Hub specification and supporting libraries for building applications on Farcaster
https://www.thehubble.xyz
MIT License
708 stars 404 forks source link

chore: add more tags to event stream metrics #2307

Closed aditiharini closed 2 months ago

aditiharini commented 2 months ago

In order to better understand how the stale event processing and the event-specific codepaths impact the message read latency, add tags to identify these attributes.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR adds event kind and stale/not stale tags to event processing metrics in the HubEventStreamConsumer class.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: f24049b2c3ca9558be1fe6726c6d46d7197cb19b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------ | ----- | | @farcaster/shuttle | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:44pm
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.31%. Comparing base (1880070) to head (f24049b). Report is 344 commits behind head on main.

Files with missing lines Patch % Lines
packages/shuttle/src/shuttle/eventStream.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2307 +/- ## =========================================== - Coverage 74.05% 44.31% -29.75% =========================================== Files 99 146 +47 Lines 9425 25498 +16073 Branches 2097 9094 +6997 =========================================== + Hits 6980 11299 +4319 - Misses 2327 12440 +10113 - Partials 118 1759 +1641 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.