fix: add request length limit for getAllMessagesBySyncIds

aditiharini commented 17 hours ago

We've observed hub memory usage and disk reads spike over the last couple days. We'd like to put a size bound on getAllMessagesBySyncIds because it currently accepts an unlimited number of sync ids and could end up exhausting hub resources.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

[x] PR title adheres to the conventional commits standard
[x] PR has a changeset
[x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
[ ] PR includes documentation if necessary.

PR-Codex overview

This PR focuses on adding a request length limit for the getAllMessagesBySyncIds function in the server.ts file and refactoring the message retrieval logic in syncHealth.ts to handle multiple requests efficiently.

Detailed summary

Added a check for the length of syncIds in getAllMessagesBySyncIds to enforce a maximum limit.
Changed the message retrieval logic in syncHealth.ts to accumulate messages from multiple requests into allMessages.
Updated the error handling to ensure consistent error responses.