bug: label field on signers is required in Hubble but optional in Hub spec

farcasterxyz / hub-monorepo

Implementation of the Farcaster Hub specification and supporting libraries for building applications on Farcaster

https://www.thehubble.xyz

MIT License

708 stars 404 forks source link

bug: label field on signers is required in Hubble but optional in Hub spec #644

Closed gskril closed 1 year ago

gskril commented 1 year ago

What is the bug? Label field on signers is optional according to the Farcaster Hub spec (discussed in https://github.com/farcasterxyz/protocol/pull/65 and https://github.com/farcasterxyz/hubble/issues/620) but required in Hubble packages (specifically packages/protobufs).

It's not a critical issue for Hubble to be more strict than the protocol, but it caught my attention when working on a Hub indexer that uses some types from the Hubble packages so I wanted to make sure it's intentional.

varunsrin commented 1 year ago

good catch, will review.

pfletcherhill commented 1 year ago

@gskril can you share an example where signer name is required? You should be able to do SignerAddBody.create({ signer: ... }) without name, though maybe you're talking about makeSignerAdd?