search

farcrycore / core

FarCry Core: a web app framework for the ColdFusion language (supporting Lucee & Adobe ColdFusion engines). An ideal platform for building bespoke or tailor made solutions.
http://www.farcrycore.org
GNU General Public License v3.0
34 stars 20 forks source link

FC-2860 : Warn user of unsaved content when closing editor : Displaye… #78

Closed cfmitrah closed 6 years ago

cfmitrah commented 6 years ago

…d the warning message of unsaved content when closing editor.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

cfmitrah commented 6 years ago

@justincarter Reminder for review :)

shib71 commented 6 years ago

The line on 321 refers to 'event', which doesn't exist, and the alert message isn't clear - it should be clearer e.g. "Are you sure you want to close without saving?"

justincarter commented 6 years ago

Thanks CF Mitrah, sorry for not getting to these PRs earlier. As Blair mentioned this change won't work with the undefined event object. We would also need some slightly more complex logic for detecting when a form has changes and not been saved, while still supporting some dialogs which might not contain a form. I think we can address this during a refactor of the Bootstrap modals, probably during a Bootstrap upgrade. I'll close this PR for now.