search

farcrycore / core

FarCry Core: a web app framework for the ColdFusion language (supporting Lucee & Adobe ColdFusion engines). An ideal platform for building bespoke or tailor made solutions.
http://www.farcrycore.org
GNU General Public License v3.0
34 stars 20 forks source link

FC-45 :: #79

Closed cfmitrah closed 6 years ago

cfmitrah commented 6 years ago
cfmitrah commented 6 years ago

@mjb I've fixed the issue mentioned in https://farcry.jira.com/browse/CMS-45. Please check that & let us know anything needed.

Thanks

cfmitrah commented 6 years ago

@justincarter Reminder for review :)

shib71 commented 6 years ago

This change will disable the field for any navigation object that has an alias set. In practice, the field should only be disabled if it is set to one of the values FarCry depends on.

justincarter commented 6 years ago

Instead of making this change in the generic "field" formtool we should probably customise the dmNavigation edit handler to override the behaviour of the lNavIDAlias field so that it's disabled when the value matches the built-in nav aliases used by core (root, home, hidden, rubbish are the main ones). I'll close this PR.

justincarter commented 6 years ago

For reference, this was the eventual solution, to override the edit method of the lNavIDAlias property in dmNavigation;

https://github.com/farcrycore/core/commit/8806c9465aa93cbe19ec9ad8d236a6f8e76b6d4c