farend / redmine_message_customize

This is a plugin for Redmine.
GNU General Public License v2.0
29 stars 11 forks source link

Strictly check that the plugin's custom locales are loaded #64

Closed hidakatsuya closed 5 months ago

hidakatsuya commented 5 months ago

I encountered a failing test, while trying to add a GitHub Actions workflow for automated testing to this repository. https://github.com/hidakatsuya/redmine_message_customize/actions/runs/9343817907/job/25713963042

The reason the above test fails is that the path of the directory where GitHub Actions runs the workflow is /home/runner/work/redmine_message_customize. As a result, the customizable_plugin_message? method always returns true. https://github.com/farend/redmine_message_customize/blob/04df5293d3715745de8f48f322679f39626dce48/lib/message_customize/locale.rb#L47-L49

This pull request addresses and resolves this issue.

I have confirmed the followings:

The environment in which I confirmed these things is as follows:

Environment:
  RedMica version                3.0.0.stable (based on Redmine 5.1.2.devel)
  Ruby version                   3.2.4-p170 (2024-04-23) [aarch64-linux]
  Rails version                  7.1.2
  Environment                    development
  Database adapter               SQLite
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
Redmine settings:
  Redmine theme                  Bleuclair (includes JavaScript)
SCM:
  Subversion                     1.14.2
  Mercurial                      6.3.2
  Cvs                            1.12.13
  Bazaar                         3.3.2
  Git                            2.39.2
  Filesystem                     
Plugins:
  redmine_message_customize      1.0.0
ishikawa999 commented 5 months ago

Thank you for the pull request. I have reviewed the code and operation check, and since there were no issues, I will merge it.