farend / redmine_theme_farend_bleuclair

Custom theme for Redmine. Compatible with: Redmine 3.4 - 5.0
GNU General Public License v2.0
109 stars 19 forks source link

Improves webpack and updates Font Awesome #71

Closed dkastl closed 11 months ago

dkastl commented 1 year ago

This pull request does the following:

dkastl commented 1 year ago

@ishikawa999 , let me know what you think about updating to Font Awesome 6.

I saw that two variants are used: Solid and Regular. But Regular has a lot less icons than Solid. Wouldn't it be easier to use only icons of type Solid? This would simplify the code.

dkastl commented 1 year ago

Let me share this link to clarify the previous comment: https://fontawesome.com/search?o=r&m=free Looking at the sidebar it shows that there are 1390 solid icons and 163 regular icons, so I would assume that for every solid icon there exists a regular icon as well.

ishikawa999 commented 1 year ago

@dkastl I agree with your thoughts. There doesn't seem to be a compelling reason to use both Solid and Regular icons. Switching from Regular to Solid icons doesn't appear to make things less readable, so unifying to Solid icons seems like a good approach.

dkastl commented 1 year ago

Thank you! I thought there might be certain reasons for your choices, but if you agree with using solid type only, then this probably makes the code more readable and also loads one font file less.

I will create another pull request for this then.

dkastl commented 1 year ago

@ishikawa999 , as mentioned in my previous comment I created another pull request: https://github.com/farend/redmine_theme_farend_bleuclair/pull/72

ishikawa999 commented 11 months ago

@dkastl

I apologize for the delay in reviewing. I ran the code on my end and didn't find any issues, so I'm planning to merge it.