Closed dkastl closed 11 months ago
@ishikawa999 , let me know what you think about updating to Font Awesome 6.
I saw that two variants are used: Solid
and Regular
. But Regular
has a lot less icons than Solid
. Wouldn't it be easier to use only icons of type Solid
? This would simplify the code.
Let me share this link to clarify the previous comment: https://fontawesome.com/search?o=r&m=free Looking at the sidebar it shows that there are 1390 solid icons and 163 regular icons, so I would assume that for every solid icon there exists a regular icon as well.
@dkastl I agree with your thoughts. There doesn't seem to be a compelling reason to use both Solid and Regular icons. Switching from Regular to Solid icons doesn't appear to make things less readable, so unifying to Solid icons seems like a good approach.
Thank you! I thought there might be certain reasons for your choices, but if you agree with using solid type only, then this probably makes the code more readable and also loads one font file less.
I will create another pull request for this then.
@ishikawa999 , as mentioned in my previous comment I created another pull request: https://github.com/farend/redmine_theme_farend_bleuclair/pull/72
@dkastl
I apologize for the delay in reviewing. I ran the code on my end and didn't find any issues, so I'm planning to merge it.
This pull request does the following:
stylesheets
andjavascripts
to the pre-commit hook