search

farengeyt451 / ngx-tippy-wrapper

Angular wrapper for Tippy.js
https://farengeyt451.github.io/ngx-tippy-wrapper
MIT License
60 stars 14 forks source link

Dynamically bind ngxTippy/content properties #23

Closed EvansMatthew97 closed 2 years ago

EvansMatthew97 commented 3 years ago

Is your feature request related to a problem? Please describe. When binding [ngxTippy] or the content properties, the tippy instance does not update its content when the value changes. This requires a workaround where the service must be called to set the content, as recommended in the README.

Describe the solution you'd like Use ngOnChanges to detect updates to the ngxTippy property. This should then set the content when the property changes.

Describe alternatives you've considered I have tried using templates and setting the content manually, but both aren't optimal. Templates are difficult to use when the tooltip should be hidden (empty value).

I haven't been able to find a contributing guide, and I would happily add this feature myself.

farengeyt451 commented 3 years ago

Hi @EvansMatthew97. Yes I agree, this is kind of unconvenient beheviour. I am working on new 4.0 version of plugin. So you can find actual code base and the contibution guide there. (instead of master use v4.0 branch)

I will be glad for your contribution.

harvanchik commented 3 years ago

Looking forward to this feature.

farengeyt451 commented 2 years ago

Implemented in v.4.0.0