faressoft / onesignal

A Wrapper for OneSignal Push Notification Delivery for Node.js. Provides the minimal functionality to send notifications for iOS and Android.
MIT License
20 stars 7 forks source link

It doesn't reject on error #2

Open jdegger opened 7 years ago

jdegger commented 7 years ago

I hate the following result:

{
    errors: ['Identifier invalid format.']
}

This does not seem to reject the Promise but silently fails with an undefined value in the callback (since .id is undefined).

This is on the addDevice function

kanji-keraliya commented 6 years ago

Same here

faressoft commented 6 years ago

@jdegger @kanji-keraliya

Can you please provide a sample code and more explanation for the issue ?

kanji-keraliya commented 6 years ago

screenshot_2