search

faressoft / terminalizer

🦄 Record your terminal and generate animated gif images or share a web player
https://terminalizer.com
MIT License
15.37k stars 499 forks source link

Render hangs if watermark image path is wrong #43

Open ahaltindis opened 5 years ago

ahaltindis commented 5 years ago

Hello,

I noticed that; if the watermark image url path is wrong, render command is just hanging. I think some error message would be great because I had to search source of problem very long time.

And thank you for this great tool.

[Edit] Versions:

> node --version
v10.15.0
> terminalizer --version
0.6.0
AndydeCleyre commented 4 years ago

I'm just trying this tool now. It would just report that opengl error, so following other bug reports I manually edited the source to include app.disableHardwareAcceleration();, which seemed to work. But after 40m of "rendering" and not seeing heavy CPU usage, I aborted.

Then I found this report, and that explains it. I had created a global config, and removed from it the entire watermark section, thinking that it would just fall back to default values/none. After re-adding it, rendering actually happens.