farhadrclass / KnetNLPModelsProblems.jl

MIT License
1 stars 1 forks source link

Remove `atol` and `rtol` from parameter set #27

Open tmigot opened 1 year ago

farhadrclass commented 1 year ago

For now I need them in my cb, need to decide a better way on how to check for stopping condition in the CB @dpo I think you mentioned setting dual condition, but I am using it for moving average,,

If good with @tmigot we keep this for now till we decide what is a best stopping condition for our SR2 with Deep Learning?

tmigot commented 1 year ago

Could we pass these arguments as keyword arguments of the callback ? So, we would keep the parameter structure "clean".