farhan-helmy / carisurau

https://carisurau.com
MIT License
66 stars 37 forks source link

Migrate from uploadthing to S3 #95

Closed farhan-helmy closed 1 year ago

farhan-helmy commented 1 year ago

Migrate back from uploadthing to S3

Realll issue, I try to upload pictures during inside MRT just now but it couldn't pass through. I suspect it is because intermittent connection issue since UploadThing is using US server

adibzter commented 1 year ago

How the current implementation works?

Client -> Web Server(Singapore?) -> UploadThing (US?) or Client -> UploadThing (US?)

farhan-helmy commented 1 year ago

The later @ADIBzTER

On Mon, 14 Aug 2023 at 5:50 PM, Adib Zaini @.***> wrote:

How the current implementation works?

Client -> Web Server(Singapore?) -> UploadThing (US?) or Client -> UploadThing (US?)

— Reply to this email directly, view it on GitHub https://github.com/farhan-helmy/ratemysurau/issues/95#issuecomment-1677022444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOJOZ4RGOYJV6AB6WERLZRLXVHYHBANCNFSM6AAAAAA3PN4QVQ . You are receiving this because you were assigned.Message ID: @.***>

farhan-helmy commented 1 year ago

tolong buat dib @ADIBzTER

adibzter commented 1 year ago

Too lazy to contribute😔. Can support only

natashaamin commented 1 year ago

hiii farhan, would love to learn about infra side. may i know how can i help as a start to solve this problem?

farhan-helmy commented 1 year ago

Hello @natashaamin this issue is actually more on the code implementation side, you can take a look at customuploader component.

Currently it is uploading the image to uploadthing.com the component is a fork from uploadthing open source repo itself https://github.com/pingdotgg/uploadthing , for this issue we are planning to change that to upload to S3. I think by tweaking CustomUploader.tsx and creating function / API endpoint to upload to S3 is good enough for start.

LMK and can PM me on discord @ farhan-helmy if you need access to our AWS Account TQ

farhan-helmy commented 1 year ago

Done