farhan0581 / django-admin-autocomplete-filter

A simple Django app to render list filters in django admin using autocomplete widget.
GNU General Public License v3.0
351 stars 76 forks source link

ModuleNotFoundError: No module named 'admin_auto_filters.views' #25

Closed vanessa closed 4 years ago

vanessa commented 5 years ago

In my installation folder there's only apps.py and filters.py. Maybe it's because it's pulling from dev branch?

image

merwok commented 5 years ago

dev branch is well behind master, I guess the author used it in a previous workflow but not any more!

Can I ask why you’re not installing a release from PyPI using pip? If you really have to use a git clone, then pulling an exact tag that matches published documentation seems to be best :slightly_smiling_face:

vanessa commented 5 years ago

@merwok Hi, thanks for reaching out. I actually installed from PyPI, and the package came like this. Here's the line in my requirements file:

django-admin-autocomplete-filter==0.3
merwok commented 5 years ago

Ah! Then I don’t know why the views module isn’t there. Source code seems ok.

merwok commented 5 years ago

Both the sdist and the wheel do not contain views! Weird given that setup.py uses setuptools.find_packages which should collect all submodules in a package.

views.py seems a little weird (from testing.models import * :thinking:), but from memory setuptools doesn’t check for correctness so it’s weird.

merwok commented 5 years ago

I cloned the repo and ran python setup.py -vvv bdist_wheel, the views module was copied, so I can’t explain the problem with the distributions on PyPI. Could have been a temporary issue, or a build from the wrong commit, or something else. Bumping the version number and re-releasing dists should avoid the issue (note: using twine is a lot nicer than python setup.py sdist upload)