search

farhan0581 / django-admin-autocomplete-filter

A simple Django app to render list filters in django admin using autocomplete widget.
GNU General Public License v3.0
351 stars 76 forks source link

Package stopped working since a few days.. #40

Open yanivtoledano opened 4 years ago

yanivtoledano commented 4 years ago

Hi!

First of all, thanks for the great package. Very useful indeed an much needed for the Django admin. I've been using this package over the past few weeks and recently (i.e., over the last few days) it stopped working. Namely: selecting a field from the dropdown search does not trigger the filter to happen - it simply does nothing. Likely has to do with the commits over the last few days as referred to here. Does filtering and selecting work for you?

idchlife commented 4 years ago

@yanivtoledano same here! Strange behaviour... Hope something can be done with it đź‘Ť

merwok commented 4 years ago

When you say that it stopped working in the last few days, do you mean that the same version doesn’t work anymore, or you are installing from master and a recent change breaks things?

idchlife commented 4 years ago

@merwok version 0.6 in pypi does not apply selected filter. Version 0.5 does (despite the fact that version 0.5 needs class Media: for some bug, it works)

yanivtoledano commented 4 years ago

@merwok see @idchlife for the answer to your question. The latest pypi version does nothing with the selected filter - version 0.5 works just fine however so it's a degradation between v0.5 to v0.6.

i-m-d commented 4 years ago

same as @idchlife, selected filter does nothing, installed from pip new, not upgraded.

merwok commented 4 years ago

Do you see errors in the browser javascript console?

jaredahern commented 4 years ago

Hi @merwok! I've been seeing the same thing: 0.6 seems broken; selecting a filter value does nothing. I don't happen to see anything in my browser console. But I suspect the issue is the JS change that's already fixed in the pre_release branch in https://github.com/farhan0581/django-admin-autocomplete-filter/commit/d90905f48499bc2914308299873d73c729775d0d, since that branch seems to work. Would it be possible to push out a new Pypi version that includes the changes in that branch, at least that commit?

merwok commented 4 years ago

It seems indeed that a quick 0.6.1 release would be great!

farhan0581 commented 4 years ago

ok, will do a release today to include that fix in the JS file.

vbabiy commented 4 years ago

@farhan0581 can you push this out to pypi?

farhan0581 commented 4 years ago

Pypi version 0.6.1 released!

i-m-d commented 4 years ago

thank you @farhan0581 now works ok.

is still needed the Media class ??

class Media: pass

farhan0581 commented 4 years ago

I don't think so, it was already addressed in the version 0.6

jaredahern commented 3 years ago

I think this issue was fixed in 0.6.1.

And agreed on the media class - that should already be fixed too, with documentation in #42.