search

farhan0581 / django-admin-autocomplete-filter

A simple Django app to render list filters in django admin using autocomplete widget.
GNU General Public License v3.0
351 stars 75 forks source link

Multiselect and more #55

Open jaredahern opened 3 years ago

jaredahern commented 3 years ago

Added the ability to use a multi-select widget, and filter by the OR of the selections in that filter. This should close #17.

This work is also basically a substantial refactor of the main filter code. It addresses issues raised in #54, as well as a number of other things (e.g. the ability to use custom fields or widgets). It does not address #53, nor are the tests fully updated yet. I plan to tackle those soon, as well as hopefully adding an ability to explicitly filter by null values in the target field. (Side note, I think that #40 and #27 have already been resolved.)

I tried to make the sequence of commits generally make sense, since looking at the cumulative changes to the filters.py file is probably not too informative. Please let me know any feedback - happy to adjust as needed.

farhan0581 commented 3 years ago

Wow thats a lot of work and commits ! @jaredahern hope you have tested these changes at your end properly, I am planning to merge them on pre_release and will spare some time to test them myself to create a pip version.

jaredahern commented 3 years ago

@farhan0581 - Thanks! Yeah... I might have gotten slightly carried away. :) But I think it make it much easier to tweak in the future. As for testing, I've tried to test fairly thoroughly (some things just manually, and I'm sure that we can expand the test suite.