search

farhan0581 / django-admin-autocomplete-filter

A simple Django app to render list filters in django admin using autocomplete widget.
GNU General Public License v3.0
351 stars 75 forks source link

Setup CI to run tests using GitHub actions #72

Open browniebroke opened 2 years ago

browniebroke commented 2 years ago

Setup CI with GitHub actions. Since it's a new workflow added from a fork, it doesn't run on this pull request but you can see the build result in the actions tab of my fork.

ulgens commented 2 years ago

I'd recommend either updating deprecated and new Python / Django versions or strictly replicating what the package currently supports.

browniebroke commented 2 years ago

I've aimed at adding all versions supported by the package currently:

https://github.com/farhan0581/django-admin-autocomplete-filter/blob/0464340f7a8917afce37e80f5078e3c93a68e942/setup.py#L19

Django 3.2 doesn't pass the build at the moment, seems to require a bit more work, so I left it out of this change.

ulgens commented 2 years ago

I've aimed at adding all versions supported by the package currently:

https://github.com/farhan0581/django-admin-autocomplete-filter/blob/0464340f7a8917afce37e80f5078e3c93a68e942/setup.py#L27

3.7 is not in the current list of supported Python versions.

browniebroke commented 2 years ago

Updated

browniebroke commented 2 years ago

@farhan0581 what do you think? Since I opened this, Python 3.6 has reached EOL, so we might want to drop it as well. However, before doing further work I'd like to see if you agree with the approach first (I'd rather drop versions in a separate pull request, if you don't mind).