search

farhan678 / adwhirl

Automatically exported from code.google.com/p/adwhirl
0 stars 0 forks source link

iPhone: should Declare undeclared selectors #139

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Many devs use XCode's option to show undeclared selectors as warnings. 

In order to remove AdWhirl generated warnings the following selectors needs to 
be declared:
AdWhirlAdNetWorkRegistry.m -> networkType:
AdWhirlCustomAdView.m        -> buttonTapUp:
AdWhirlView.m                           -> 
newAdAnimationDidStopWithAnimationID:finished:context:

Clean code is always good :-)

Original issue reported on code.google.com by jacques....@gmail.com on 8 Nov 2010 at 9:27

GoogleCodeExporter commented 9 years ago

Original comment by nigelc...@google.com on 30 Nov 2010 at 9:53

GoogleCodeExporter commented 9 years ago 
In AdWhirlAdNetworkAdapter.h add: (to the typedef enum for AdWhirlAdNetworkType)

AdWhirlAdNetworkTypeUnknown           = 0,

In AdWhirlAdNetworkRegistry.h add:

+ (AdWhirlAdNetworkType)networkType;

In AdWhirlAdNetworkRegistry.m add:

+ (AdWhirlAdNetworkType)networkType {
  return AdWhirlAdNetworkTypeUnknown;
}

Original comment by d...@primc.com on 19 May 2011 at 10:19

GoogleCodeExporter commented 9 years ago 
In AdWhirlView.h add:

- (void)newAdAnimationDidStopWithAnimationID:(NSString *)animationID 
finished:(BOOL)finished context:(void *)context;

Original comment by d...@primc.com on 19 May 2011 at 10:20