farhan678 / adwhirl

Automatically exported from code.google.com/p/adwhirl
0 stars 0 forks source link

Fixed crash caused by Greystripe adapter's stopBeingDelegate method #153

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
Greystripe iPhone SDK adapter

When reviewing my code changes, please focus on:
Changes are in my clone at http://code.google.com/r/davekoslow-greystripe/. You 
can view my changes in changeset 395:07a3ccd745ab (my tip).

After the review, I'll merge this branch into:
I'll leave that to you :)

Original issue reported on code.google.com by davekos...@gmail.com on 4 Dec 2010 at 1:12

GoogleCodeExporter commented 9 years ago
thanks for the fix.  was in the middle of implementing greystripe and it 
started crashing in the very spot you mention.  someone please merge this into 
master.

Original comment by brandon%...@gtempaccount.com on 28 Dec 2010 at 9:37

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
This really needs to be updated in the AdWhirl SDK, it was a simple fix, thanks.

Original comment by twal...@gmail.com on 23 May 2011 at 1:36

GoogleCodeExporter commented 9 years ago
yeah how come this hasn't been updated yet?

Original comment by excellte...@gmail.com on 7 Jul 2011 at 8:59

GoogleCodeExporter commented 9 years ago
It seems like the crash you're describing would only occur if we implemented 
your do-nothing stopBeingDelegate method.

It's important to clear greystripe's delegate before our adapters go away, 
otherwise the GSAdView could wind up attempting to message a dealloc'd object.

Please let me know if my understanding is flawed here, and we'll reopen the 
issue.

Original comment by wesgood...@google.com on 30 Nov 2011 at 8:51