search

farhanrahman / kyoto

18 stars 7 forks source link

AbstractCountry Extraneous Reporting Functions #103

Closed Sergeus closed 12 years ago

Sergeus commented 12 years ago

There are several methods in AbstractCountry which look like they're part of the carbon reporting service, but are very confusingly named and look like they can be deprecated. They involve sharedState and all sorts of very strange things I don't quite understand enough to pull the functions out. The functions are:

addtoReports() getCarbonEmissionReports() reportCarbonEmission() getSharedState()

Can these all be removed? If not, can they be renamed?

piotroslaw commented 12 years ago

Adding to this, the function reportCarbonOuput is called twice in execute() in AbstractCountry. I assume this is an error?

Sergeus commented 12 years ago

Turns out we need to use these.