search

farhanrahman / kyoto

18 stars 7 forks source link

Data: Nigers Energy Output #99

Closed tumblerer closed 12 years ago

tumblerer commented 12 years ago

Nigers energy output is higher than their carbon Output. Not possible.

tumblerer commented 12 years ago

@webbo89 , @maxrev17 relevant also.

tumblerer commented 12 years ago

Same with mauritiaus, madagascer, guinea, grenada, barbados, belize, bhutan,

n1kunj commented 12 years ago

I read that very wrong the first time.

ncocacola commented 12 years ago

HA HA HA

On 18 June 2012 19:47, n1kunj < reply@reply.github.com

wrote:

I read that very wrong the first time.

Reply to this email directly or view it on GitHub: https://github.com/farhanrahman/kyoto/issues/99#issuecomment-6405302

ncocacola commented 12 years ago

I think I must have gotten confused with all this sorting & Excel columns etc. All other values have been corrected (with a made up Fossil Fuel % as agreed).

The new kyotoCountryData.xlsx & kyotoCountryData.csv have been pushed to my repository.

Let me know if you spot any other mistakes.

Sergeus commented 12 years ago

Isn't energy output supposed to be the higher one?

ncocacola commented 12 years ago

Yes, Stuart, you are right. I thought I'd corrected this issue last night but turns out I made yet another mistake. I re-calculated energyOutput based on carbonOutput1990 (God knows why...), not carbonOutput, so it was still wrong...

I've corrected the mistake, so energyOutput values should now (hopefully) all be correct.

Some energyOutput might not be less than carbonOutput, but exactly equal. Those are the countries that use exclusively Fossil Fuels for their Energy (i.e. where FossilFuels% == 100%) such as Bahrein.

On 19 June 2012 01:10, Stuart Holland < reply@reply.github.com

wrote:

Isn't energy output supposed to be the higher one?

Reply to this email directly or view it on GitHub: https://github.com/farhanrahman/kyoto/issues/99#issuecomment-6412861

tumblerer commented 12 years ago

I've downloaded the latest xlsx and its utter nonsense at the moment. Half the countries have energyOutput > carbonOutput and the other half have energyOutput < carbonOutput.

tumblerer commented 12 years ago

Also, could you chage GDP to $ instead of $m.

ncocacola commented 12 years ago

They were in $ initially, but the constructor in AbstractCountry was in $M.

I've changed it back to $, check my repo.

On 19 June 2012 11:44, Chris < reply@reply.github.com

wrote:

Also, could you chage GDP to $ instead of $m.

Reply to this email directly or view it on GitHub: https://github.com/farhanrahman/kyoto/issues/99#issuecomment-6421693

azyzio commented 12 years ago

why change to $?

Actually, it probably doesn't make a difference when using doubles.

tumblerer commented 12 years ago

Mainly because the amount of carbon you need to drop is in the region of 10^7+, so you were working in fractions of availiable cash. It's really just a cosmetic thing.

tumblerer commented 12 years ago

This is done for the moment