search

farhanwazir / laravelgooglemaps

Laravel Google Maps Package
MIT License
152 stars 112 forks source link

Geocoding Fix #26

Closed drehimself closed 5 years ago

drehimself commented 5 years ago

For some reason, geocoding stopped working. Lat, long coordinates are always returning 0, 0. This used to only happen sometimes but is now happening all the time. I'm not sure what changes Google Maps have made.

Add apiKey to get_lat_long_from_address method fixes the issue.

farhanwazir commented 5 years ago

Some changes made by google which needs to implement. Due to shortage of time I can't update yet. Will do very soon

On Mon, Oct 8, 2018, 10:05 AM Andre Madarang notifications@github.com wrote:

For some reason, geocoding stopped working. Lat, long coordinates are always returning 0, 0. This used to only happen sometimes but is now happening all the time. I'm not sure what changes Google Maps have made.

Add apiKey to get_lat_long_from_address method fixes the issue.

You can view, comment on, or merge this pull request online at:

https://github.com/farhanwazir/laravelgooglemaps/pull/26 Commit Summary

  • Fix geocoding issue. Add apiKey to get_lat_long_from_address method

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/farhanwazir/laravelgooglemaps/pull/26, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOwoZMTzBJMJER10rQju3h9d4_Y66wZks5uitz8gaJpZM4XMQjy .

umairalirehan commented 5 years ago

farhanwazir, plz if possible then make a video for new update package, everyone can understand better in this way

umairalirehan commented 5 years ago

and $config['center'] = '31.4661231, 74.3162962'; is working but, my this code not working "$config['center'] = 'Air Canada Centere, Toronto';", and markers work only if i add latitude and longitude in routes, not work when we add $config['center'] = 'Air Canada Centere, Toronto.

farhanwazir commented 5 years ago

I'll make an video. It's an good idea.

On Tue, Nov 6, 2018, 18:44 umair ali <notifications@github.com wrote:

and please your google markers also did not work

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/farhanwazir/laravelgooglemaps/pull/26#issuecomment-436256982, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOwoUFrz4P6lk_DJiBJ8Xwoy_jeAbMzks5usZJNgaJpZM4XMQjy .

kelluzano commented 5 years ago

Hi is there any update on this? Is geocoding is working now?

waynegakuo commented 5 years ago

@kelluzano the geocoding is working. Use @drehimself solution. It solves the issue

walyfbo commented 5 years ago

@kelluzano the geocoding is working. Use @drehimself solution. It solves the issue

Hi! I still have issues with the geocoding, can you please clarify how exactly you solved the issues ? To me, it seens that the solution proposed by @drehimself didn't worked at all, but I guess i'm doing something wrong, using $config['center'] = 'New York, USA'; still doesn't work, it only works if i pass some coordinates.

Thanks in advance!

farhanwazir commented 5 years ago

We will check and see if it has an issue

On Tue, Apr 9, 2019, 15:42 walyfbo, notifications@github.com wrote:

@kelluzano https://github.com/kelluzano the geocoding is working. Use @drehimself https://github.com/drehimself solution. It solves the issue

Hi! I still have issues with the geocoding, can you please clarify how exactly you solved the issues ? To me, it seens that the solution proposed by @drehimself https://github.com/drehimself didn't worked at all, but I guess i'm doing something wrong, using $config['center'] = 'New York, USA'; still doesn't work, it only works if i pass some coordinates.

Thanks in advance!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/farhanwazir/laravelgooglemaps/pull/26#issuecomment-481199676, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOwoXgwLEO7XZUwNClZI22MADepaYUxks5vfG6cgaJpZM4XMQjy .

waynegakuo commented 5 years ago

@walyfbo, the solution by @drehimself was to address the issue of new way of Geocode requests. Google Maps APIs did a bit of changes on how to process some of the Maps requests.

farhanwazir commented 5 years ago

fixed