Open phelps-matthew opened 4 years ago
Just to follow up - I am curious if you have a screenshot of the expected ipython scheme. The hex color codes in the style.py look good to me, but things like the red on error messages, for example, look darker than the BRIGHT_RED = '#fb4934'
setting in the GruvboxBase class definition.
Here is my output
Thank you for using it!
No that's not what was intended at all and I appreciate you pointing this out. After getting the repository set up, I began modifying the original colorscheme to more closely reflect a gruvbox-material repo I found. However, that wasn't mentioned in the README.
I'm currently updating this but as I've been going I noticed a few more inconsitencies that I'm still trying to iron out.
However, if you'd like to fork the repo and continue some work on it, I'd definitely encourage that and love to see any changes you make if you'd consider pushing them back to master!
Just to follow up - I am curious if you have a screenshot of the expected ipython scheme. The hex color codes in the style.py look good to me, but things like the red on error messages, for example, look darker than the
BRIGHT_RED = '#fb4934'
setting in the GruvboxBase class definition.
I've been meaning to upload screenshots since the day I created this. I'll make sure I get on that. I've also noticed that, but unfortunately I can't tell what it originates from. Frankly it seems to be a discrepency in how vim and pygments process colors because if you set the colorscheme similarly using prompt_toolkit, ipython, pygments, or xonsh they display the same.
Thanks for the comments. I haven't gotten back to it for a few days, but here is where I have left off. I was able to modify the ipython prompt and prompt number to a desired color by making adjustments to ~/.ipython/profile_default/ipython_config.py
. Particularly
c.TerminalInteractiveShell.highlighting_style_overrides
I'll fork and send your way if I ever make decent progress and have something usable.
Take your time I'll be here haha.
Would you be able to paste the contents of the file you linked to?
A link to a gist would also work.
Is there a better way to embed this?
Lol a url works just fine.
## Override highlighting format for specific tokens
c.TerminalInteractiveShell.highlighting_style_overrides = {
Token.Prompt: "#b8bb26",
Token.PromptNum: "#b8bb26",
}
I think this is the only part I needed anyway
Hi, thanks for creating this. After following the readme,I received a module not found error for pyments.styles.Gruvbox. Seems I was able to get it working by setting in ipython_config.py
Is this what was intended?
As it is, it seems the gruvbox colors are darker and more contrasting than what I run in vim. I might try changing some of the pallet.